Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR-1] added Jupyter Notebook dependency for installation #123

Merged
merged 6 commits into from
Mar 29, 2024
Merged

[PR-1] added Jupyter Notebook dependency for installation #123

merged 6 commits into from
Mar 29, 2024

Conversation

jonatng
Copy link
Contributor

@jonatng jonatng commented Mar 17, 2024

Jupyter Notebook installation is needed when installing promptTools

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@HashemAlsaket
Copy link
Contributor

HashemAlsaket commented Mar 17, 2024 •
edited
Loading

Awesome catch 🚀🚀🚀

@jonatng
Copy link
Contributor Author

jonatng commented Mar 20, 2024

Hi @NivekT @steventkrawczyk
Can I get some eyes on this PR please

NivekT
NivekT requested changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR!

I think it should be added to the Quick Start section, possibly here:

cd prompttools && jupyter notebook examples/notebooks/OpenAIChatExperiment.ipynb

NivekT
NivekT requested changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change should still be in README but below

You can run a simple example of a `prompttools` locally with the following

NivekT
NivekT requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip install notebook should be in README not in a single Jupyter notebook

@jonatng
Copy link
Contributor Author

jonatng commented Mar 29, 2024

@NivekT Added pip install notebook to README
Would you like to keep or remove pip install notebook from prompttools/examples/notebooks/OpenAIChatExperiment.ipynb

NivekT
NivekT reviewed Mar 29, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
examples/notebooks/OpenAIChatExperiment.ipynb Outdated Show resolved Hide resolved
NivekT
NivekT reviewed Mar 29, 2024
View reviewed changes
README.md
You can run a simple example of a `prompttools` locally with the following

```
pip install notebook # If jupyter notebook has not been installed
Copy link
Collaborator

@NivekT NivekT Mar 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install notebook # If jupyter notebook has not been installed
pip install notebook # If jupyter notebook has not been installed

@NivekT NivekT merged commit 518bff4 into hegelai:main Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NivekT NivekT NivekT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonatng @CLAassistant @HashemAlsaket @NivekT